shunping commented on code in PR #30262: URL: https://github.com/apache/beam/pull/30262#discussion_r1484421760
########## scripts/tools/gcpbomupgrader.py: ########## @@ -0,0 +1,212 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +import errno +import logging +import os +import re +import subprocess +import sys +""" +This Python script is used for upgrading the GCP-BOM in BeamModulePlugin. +Specifically, it + +1. preprocessing BeamModulePlugin.groovy to decide the dependencies need to sync +2. generate an empty Maven project to fetch the exact target versions to change +3. Write back to BeamModulePlugin.groovy + +There are few reasons we need to declare the version numbers: +1. Sync the dependency that not included in GCP-BOM with those included with BOM + For example, "com.google.cloud:google-cloud-spanner" does while "com.google.cloud:google-cloud-spanner:():test" doesn't +2. There are Beam artifacts not depending on GCP-BOM but used dependency managed Review Comment: Could you also document what we should change BeamModulePlugin if we have a new dep that we want to pin and we want to leverage this tool later (or at least don't break the standardization)? There are two cases here: 1) adding a new dep from a project that is already tracked in BeamModulePlugin, and 2) adding a new dep from a new project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
