tvalentyn commented on code in PR #28564:
URL: https://github.com/apache/beam/pull/28564#discussion_r1484578197
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner_test.py:
##########
@@ -211,15 +211,13 @@ def
test_environment_override_translation_legacy_worker_harness_image(self):
p | ptransform.Create([1, 2, 3])
| 'Do' >> ptransform.FlatMap(lambda x: [(x, x)])
| ptransform.GroupByKey())
- self.assertEqual(
- list(remote_runner.proto_pipeline.components.environments.values()),
- [
- beam_runner_api_pb2.Environment(
- urn=common_urns.environments.DOCKER.urn,
- payload=beam_runner_api_pb2.DockerPayload(
- container_image='LEGACY').SerializeToString(),
- capabilities=environments.python_sdk_docker_capabilities())
- ])
+ first = remote_runner.proto_pipeline.components.environments.values()
+ second = beam_runner_api_pb2.Environment(
+ urn=common_urns.environments.DOCKER.urn,
+ payload=beam_runner_api_pb2.DockerPayload(
+ container_image='LEGACY').SerializeToString(),
+ capabilities=environments.python_sdk_docker_capabilities())
+ self.assertTrue(first.__eq__(second))
Review Comment:
strange, have you seen what's the diff? New condition looks as though we
compare a list of environments (first), with a single environment (second)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
