Abacn commented on code in PR #30235:
URL: https://github.com/apache/beam/pull/30235#discussion_r1486639162
##########
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/CoderTranslationTest.java:
##########
@@ -152,14 +150,12 @@ public static Iterable<Coder<?>> data() {
StringUtf8Coder.of(),
SerializableCoder.of(Record.class),
new RecordCoder(),
- KvCoder.of(
Review Comment:
Can we preserve the test with AvroCoder here? It sounds fine to me that
runners-core-construction depend on the avro module (even though main jar
doesn't).
EDIT: I see it may introduce circular dependency. How about add a test like
originally this one does in the extensions/avro module? like
sdks/java/extensions/avro/src/test/java/org/apache/beam/sdk/extensions/avro/AvroCoderTranslationTest.java
##########
runners/direct-java/build.gradle:
##########
@@ -40,9 +40,6 @@ applyJavaNature(
include(project(path: it, configuration: "shadow"))
}
}
- relocate "org.apache.beam.runners.core",
getJavaRelocatedPath("runners.core")
Review Comment:
Would you mind explain a little bit this change? (what was the purposes of
relocation here and why now it is no longer necessary, if possible)
##########
runners/direct-java/src/main/java/org/apache/beam/runners/direct/TransformEvaluatorRegistry.java:
##########
@@ -132,9 +131,6 @@ public static class DirectTransformsRegistrar implements
TransformPayloadTransla
.put(
DirectTestStream.class,
TransformPayloadTranslator.NotSerializable.forUrn(DIRECT_TEST_STREAM_URN))
- .put(
Review Comment:
If I understood correctly, this is because we now have an AutoService in
runners/core-java/src/main/java/org/apache/beam/runners/core/SplittableParDoViaKeyedWorkItems.java,
so no loner explicit register SplittableParDoViaKeyedWorkItems?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
