robertwb commented on PR #29834: URL: https://github.com/apache/beam/pull/29834#issuecomment-1939774160
Ah, yes, that's right. Hopefully the file generation itself isn't *that* slow. On Mon, Feb 12, 2024 at 3:02 PM Ahmed Abualsaud ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In sdks/python/setup.py > <https://github.com/apache/beam/pull/29834#discussion_r1486898981>: > > > + # if exists, this directory will have at least its __init__.py file > + if (not os.path.exists(generated_transforms_dir) or > + len(os.listdir(generated_transforms_dir)) <= 1): > + message = 'External transform wrappers have not been generated ' > + if not script_exists: > + message += 'and the generation script `gen_xlang_wrappers.py`' > + if not config_exists: > + message += 'and the standard external transforms config' > + message += ' could not be found' > + warnings.warn(message) > + else: > + warnings.warn( > + 'Skipping external transform wrapper generation as they ' > + 'are already generated.') > + return > + out = subprocess.run([ > > This will make pretty much every run of setup.py slow, right? > > Not anymore, since we decided to decouple the generation steps. setup.py > expects the transform config to already exist, so no expansion + discovery > is done here. All it does is generate files based on the existing config. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/29834#discussion_r1486898981>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/AADWVAJPRS6PTJHJGTPTHE3YTKNPZAVCNFSM6AAAAABA4ZG2QSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNZWGUYTSNZSGA> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
