kennknowles commented on code in PR #30283:
URL: https://github.com/apache/beam/pull/30283#discussion_r1488067223
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnHarness.java:
##########
@@ -144,6 +171,8 @@ public static void main(Function<String, String>
environmentVarGetter) throws Ex
}
System.out.format("Pipeline options %s%n", pipelineOptionsJson);
+ pipelineOptionsJson = removeNestedKey(pipelineOptionsJson,
"impersonateServiceAccount");
Review Comment:
My comment sounds too negative - I mean to say that I am OK with this but we
need to track the follow-up, make a clear comment, and handle it in Dataflow
better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
