Abacn commented on code in PR #30286:
URL: https://github.com/apache/beam/pull/30286#discussion_r1496348832
##########
it/google-cloud-platform/build.gradle:
##########
@@ -72,13 +73,16 @@ dependencies {
testImplementation project(path: ":sdks:java:testing:test-utils")
testImplementation project(path: ":sdks:java:io:google-cloud-platform")
+ testImplementation project(path: ":sdks:java:extensions:protobuf",
configuration: "testRuntimeMigration")
testImplementation project(path: ":sdks:java:io:synthetic")
testImplementation library.java.mockito_inline
testImplementation project(path:
":sdks:java:extensions:google-cloud-platform-core", configuration:
"testRuntimeMigration")
+ testImplementation project(path: ":runners:direct-java", configuration:
"shadow")
Review Comment:
Why this is needed. There are "testRuntimeOnly" below.
If it is the case, then we can remove the line below.
##########
it/google-cloud-platform/build.gradle:
##########
@@ -41,6 +41,7 @@ dependencies {
implementation 'org.apache.parquet:parquet-avro:1.12.0'
implementation 'org.apache.parquet:parquet-common:1.12.0'
implementation 'org.apache.parquet:parquet-hadoop:1.12.0'
+ implementation 'org.apache.commons:commons-lang3:3.9@jar'
Review Comment:
implementation library.java.commons_lang3 in align with dependency
declaration conventions in Beam?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
