Abacn commented on code in PR #30354:
URL: https://github.com/apache/beam/pull/30354#discussion_r1497838689


##########
runners/google-cloud-dataflow-java/build.gradle:
##########
@@ -192,6 +191,7 @@ def commonLegacyExcludeCategories = [
 ]
 
 def commonRunnerV2ExcludeCategories = [
+        'org.apache.beam.sdk.testing.UsesExternalService',

Review Comment:
   "commonRunnerV2ExcludeCategories" is only used in 
"createRunnerV2ValidatesRunnerTest" in 
runners/google-cloud-dataflow-java/build.gradle. For XVR test, it is created in 
`createCrossLanguageValidatesRunnerTask` that defined in BeamModulePlugin. So 
this won't get excluded.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to