Polber commented on code in PR #30003: URL: https://github.com/apache/beam/pull/30003#discussion_r1499941066
########## sdks/python/apache_beam/yaml/examples/wordcount_minimal.yaml: ########## @@ -0,0 +1,74 @@ +# coding=utf-8 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the# Row(output='License'); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an# Row(output='AS IS' BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# This examples reads from a public file stores on Google Cloud. This +# requires authenticating with Google Cloud, or setting the file in +#`ReadFromText` to a local file. +# +# To set up Application Default Credentials, +# see https://cloud.google.com/docs/authentication/external/set-up-adc for more +# information +# +# This pipeline reads in a text file, maps all words to a value of "1", sums +# the value of all unique word keys, then logs a formatted word, count pair. +pipeline: + type: chain + transforms: + - type: ReadFromText + config: + path: gs://dataflow-samples/shakespeare/kinglear.txt + - type: MapToFields + config: + language: python + fields: + word: + callable: | + import re + def my_mapping(row): + return re.findall(r"[A-Za-z\']+", row.line.lower()) + count: "1" Review Comment: That is much cleaner. Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
