robertwb commented on code in PR #30317:
URL: https://github.com/apache/beam/pull/30317#discussion_r1501142124


##########
model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto:
##########
@@ -1075,6 +1111,42 @@ message StateClearRequest {}
 // A response to clear state.
 message StateClearResponse {}

Review Comment:
   Thanks. 
   
   IIUC, append is still correct, as there's a bag (with possibly multiple 
items) assigned to every point in the ordered space. (It's a lot like MultiMap 
with the ability to read ranges in order rather than just do point lookups, 
though +1 to not mixing the two.) 
   
   Agree on caching--there are more clever things we can do here in the future, 
but we can punt that to future work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to