Abacn commented on code in PR #30442:
URL: https://github.com/apache/beam/pull/30442#discussion_r1504994063
##########
sdks/java/extensions/avro/build.gradle:
##########
@@ -100,9 +100,9 @@ avroVersions.each { k, v ->
}
// only use compileClasspath on purpose to not include generated test
files
- // will recompile with the propper generated sources
+ // will recompile with the proper generated sources
compileClasspath += sourceSets.main.output +
configurations."avroVersion$k"
- runtimeClasspath += configurations."avroVersion$k"
+ runtimeClasspath += sourceSets.main.output +
configurations."avroVersion$k"
Review Comment:
It worked before possibly because core-construction-java previously depend
on extensions/avro, so the main classes were in test runtime class path. But it
is not the case after #30235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
