mzitnik commented on code in PR #29715:
URL: https://github.com/apache/beam/pull/29715#discussion_r1506273978
##########
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/TableSchema.java:
##########
@@ -111,6 +112,14 @@ public static Schema.FieldType
getEquivalentFieldType(ColumnType columnType) {
return Schema.FieldType.STRING;
case BOOL:
return Schema.FieldType.BOOLEAN;
+ case TUPLE:
+ List<Schema.Field> fields =
+ columnType.tupleTypes().entrySet().stream()
+ .map(x -> Schema.Field.of(x.getKey(),
Schema.FieldType.DATETIME))
Review Comment:
@erube and @wattache, thanks for the feedback i will fork and also add some
tests to cover Array(Tuple(*))
##########
sdks/java/io/clickhouse/src/main/java/org/apache/beam/sdk/io/clickhouse/TableSchema.java:
##########
@@ -111,6 +112,14 @@ public static Schema.FieldType
getEquivalentFieldType(ColumnType columnType) {
return Schema.FieldType.STRING;
case BOOL:
return Schema.FieldType.BOOLEAN;
+ case TUPLE:
+ List<Schema.Field> fields =
+ columnType.tupleTypes().entrySet().stream()
+ .map(x -> Schema.Field.of(x.getKey(),
Schema.FieldType.DATETIME))
Review Comment:
@erube and @wattache, thanks for the feedback i will fork and also add some
tests to cover `Array(Tuple(*))`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
