MelodyShen commented on PR #30439: URL: https://github.com/apache/beam/pull/30439#issuecomment-1972398557
Hi @scwhittle sorry I rebased the branch incorrectly which caused the previous commit history got lost. The main changes since last review are: 1. BoundedQueueExecutor: Use synchronized instead of Atomic for all the thread-unsafe fields. 2. StreamingDataflowWorkerTest: update test 3. Added a new test file BoundedQueueExecutorTest to test behaviors related to maximumThreadCount and TotalMaxThreadActiveTimeUsed. Thanks for your time! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
