Abacn commented on code in PR #30491:
URL: https://github.com/apache/beam/pull/30491#discussion_r1511974476


##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -2890,7 +2890,8 @@ class BeamModulePlugin implements Plugin<Project> {
           def cmdArgs = 
project.project(':sdks:python').mapToArgString(beamPythonTestPipelineOptions)
 
           project.exec {
-            environment "EXPANSION_PORT", externalPort

Review Comment:
   could this rename affect existing tests relying on EXPANSION_PORT, or it was 
just a typo and should be fixed by this change?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to