ettirapp commented on a change in pull request #12581:
URL: https://github.com/apache/beam/pull/12581#discussion_r472639381
##########
File path:
sdks/java/io/azure/src/main/java/org/apache/beam/sdk/io/azure/blobstore/AzfsResourceId.java
##########
@@ -156,8 +190,6 @@ public int hashCode() {
@Override
public ResourceId resolve(String other, ResolveOptions resolveOptions) {
checkState(isDirectory(), "Expected this resource to be a directory, but
was [%s]", toString());
- // TODO: check if resolve options are an illegal name in any way, see:
Review comment:
I decided that it makes most sense to check that a filename is valid in
the `create` method of the AzureBlobStoreFileSystem, where a new file is
created. In the `create` method, the `getBlobOutputStream()` method will throw
a BlobStorageException if a filename is invalid.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
