kennknowles commented on issue #30469: URL: https://github.com/apache/beam/issues/30469#issuecomment-1986199984
Really unusual that we didn't hit this before. The codepaths are clearly internally inconsistent. You can't do a dual (v1 and v2 combined) submission when one of the codepaths doesn't even have a way to translate/implement (the v1 translation will fail or just be totally wrong). I think what we want to do if we find features used that make v1 unusable is to truly just zero out the whole v1 submission. This should happen in the DataflowRunner not in KafkaIO. Your change to just not do the override is a decent mitigation since I don't think we have a good way otherwise. But just having some `V1UnsupportedFeatureException(String)` and then catching that at the top level and setting the v1beta3 `workflow` to null would be the ultimate goal. Not sure if that will confuse downstream stuff though... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
