kennknowles commented on PR #30545: URL: https://github.com/apache/beam/pull/30545#issuecomment-1989279290
OK this is ready for review. I don't know if you all are interested in reviewing it or I will also CC @robertwb. I think the separate commits might be easier to review separately (I'm happy to put them in their own PR but also just focusing a review on a particular code root is equivalent) 1. model proto 2. Java SDK impl with translation to proto 3. Each runner - I did Dataflow first but then Spark had test failures so I guess basic GBK fails to preserve metadata so I just went ahead and added translations to Spark, Flink, Samza too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
