kennknowles commented on code in PR #30622:
URL: https://github.com/apache/beam/pull/30622#discussion_r1523588647
##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java:
##########
@@ -413,12 +411,15 @@ public void translateNode(
outputType,
FlinkIdentityFunction.of(),
getCurrentTransformName(context));
- final Configuration partitionOptions = new Configuration();
- partitionOptions.setString(
- Optimizer.HINT_SHIP_STRATEGY,
Optimizer.HINT_SHIP_STRATEGY_REPARTITION);
Review Comment:
Commented on the bug, but _if_ Flink really looks at these hints, I think
the implementation here is good. It is better to translate it as a hint that
Flink understands than to force it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
