scwhittle commented on code in PR #30588: URL: https://github.com/apache/beam/pull/30588#discussion_r1530507529
########## runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/options/DataflowStreamingPipelineOptions.java: ########## @@ -211,6 +211,14 @@ public interface DataflowStreamingPipelineOptions extends PipelineOptions { void setWindmillServiceStreamMaxBackoffMillis(int value); + @Description( + "If true, Dataflow streaming pipeline will be running in direct path mode." + + " VMs must have IPv6 enabled for this to work.") + @Default.Boolean(false) + boolean getIsWindmillServiceDirectPathEnabled(); + + void setIsWindmillServiceDirectPathEnabled(boolean isWindmillServiceDirectPathEnabled); Review Comment: I would remove the `is`, otherwise specifying the flag looks odd IMO `--isWindmillServiceDirectPathEnabled=true` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org