kennknowles commented on code in PR #30545:
URL: https://github.com/apache/beam/pull/30545#discussion_r1531106246
##########
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java:
##########
@@ -917,6 +919,41 @@ private <K1, K2, V> void groupByKeyAndSortValuesHelper(
}
});
+ registerTransformTranslator(
+ RedistributeByKey.class,
Review Comment:
@robertwb you might be the person to review DataflowRunner translation? For
Reshuffle we don't have a translator but a more complex rewrites to a
specialized GroupByKey. I opted to _not_ do that this time but translate more
directly. I added ValidatesRunner tests for Redistribute that check parity with
Reshuffle, at least in terms of that test suite.
CC @scwhittle
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
