Abacn commented on code in PR #30704:
URL: https://github.com/apache/beam/pull/30704#discussion_r1535847194
##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -44,120 +44,123 @@ lint.dependsOn mypyPy38
apply from: "../common.gradle"
-
-// PyCoverage Precommit runs test suites that evaluate test coverage and
compatibility of
-// particular dependencies. It is exercised on a single Python version.
+toxTask "testPy38CloudCoverage", "py38-cloudcoverage", "${posargs}"
+test.dependsOn "testPy38CloudCoverage"
project.tasks.register("preCommitPyCoverage") {
dependsOn = ["testPy38CloudCoverage"]
}
+// Dep Postcommit runs test suites that evaluate compatibility of particular
+// dependencies. It is exercised on a single Python version.
+project.tasks.register("postCommitPyDep") {}
+
// Create a test task for each supported major version of pyarrow
toxTask "testPy38pyarrow-3", "py38-pyarrow-3", "${posargs}"
test.dependsOn "testPy38pyarrow-3"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-3"
+postCommitPyDep.dependsOn "testPy38pyarrow-3"
toxTask "testPy38pyarrow-4", "py38-pyarrow-4", "${posargs}"
test.dependsOn "testPy38pyarrow-4"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-4"
+postCommitPyDep.dependsOn "testPy38pyarrow-4"
toxTask "testPy38pyarrow-5", "py38-pyarrow-5", "${posargs}"
test.dependsOn "testPy38pyarrow-5"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-5"
+postCommitPyDep.dependsOn "testPy38pyarrow-5"
toxTask "testPy38pyarrow-6", "py38-pyarrow-6", "${posargs}"
test.dependsOn "testPy38pyarrow-6"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-6"
+postCommitPyDep.dependsOn "testPy38pyarrow-6"
toxTask "testPy38pyarrow-7", "py38-pyarrow-7", "${posargs}"
test.dependsOn "testPy38pyarrow-7"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-7"
+postCommitPyDep.dependsOn "testPy38pyarrow-7"
toxTask "testPy38pyarrow-8", "py38-pyarrow-8", "${posargs}"
test.dependsOn "testPy38pyarrow-8"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-8"
+postCommitPyDep.dependsOn "testPy38pyarrow-8"
Review Comment:
From #30226 Only pyarrow and pandas tests were executed in other PreCommit
(PreCommit dataframe), so these two tests can be fully moved to postcommit;
other tests leave at least one version in PreCommit coverage
##########
sdks/python/test-suites/tox/py38/build.gradle:
##########
@@ -44,120 +44,123 @@ lint.dependsOn mypyPy38
apply from: "../common.gradle"
-
-// PyCoverage Precommit runs test suites that evaluate test coverage and
compatibility of
-// particular dependencies. It is exercised on a single Python version.
+toxTask "testPy38CloudCoverage", "py38-cloudcoverage", "${posargs}"
+test.dependsOn "testPy38CloudCoverage"
project.tasks.register("preCommitPyCoverage") {
dependsOn = ["testPy38CloudCoverage"]
}
+// Dep Postcommit runs test suites that evaluate compatibility of particular
+// dependencies. It is exercised on a single Python version.
+project.tasks.register("postCommitPyDep") {}
+
// Create a test task for each supported major version of pyarrow
toxTask "testPy38pyarrow-3", "py38-pyarrow-3", "${posargs}"
test.dependsOn "testPy38pyarrow-3"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-3"
+postCommitPyDep.dependsOn "testPy38pyarrow-3"
toxTask "testPy38pyarrow-4", "py38-pyarrow-4", "${posargs}"
test.dependsOn "testPy38pyarrow-4"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-4"
+postCommitPyDep.dependsOn "testPy38pyarrow-4"
toxTask "testPy38pyarrow-5", "py38-pyarrow-5", "${posargs}"
test.dependsOn "testPy38pyarrow-5"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-5"
+postCommitPyDep.dependsOn "testPy38pyarrow-5"
toxTask "testPy38pyarrow-6", "py38-pyarrow-6", "${posargs}"
test.dependsOn "testPy38pyarrow-6"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-6"
+postCommitPyDep.dependsOn "testPy38pyarrow-6"
toxTask "testPy38pyarrow-7", "py38-pyarrow-7", "${posargs}"
test.dependsOn "testPy38pyarrow-7"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-7"
+postCommitPyDep.dependsOn "testPy38pyarrow-7"
toxTask "testPy38pyarrow-8", "py38-pyarrow-8", "${posargs}"
test.dependsOn "testPy38pyarrow-8"
-preCommitPyCoverage.dependsOn "testPy38pyarrow-8"
+postCommitPyDep.dependsOn "testPy38pyarrow-8"
Review Comment:
From test result of #30226 Only pyarrow and pandas tests were executed in
other PreCommit (PreCommit dataframe), so these two tests can be fully moved to
postcommit; other tests leave at least one version in PreCommit coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
