tvalentyn commented on code in PR #30740:
URL: https://github.com/apache/beam/pull/30740#discussion_r1538267906
##########
examples/notebooks/beam-ml/bigtable_enrichment_transform.ipynb:
##########
@@ -753,70 +758,41 @@
" def process(self, element, *args, **kwargs):\n",
" element_dict = json.loads(element.decode('utf-8'))\n",
" yield beam.Row(**element_dict)"
- ],
- "metadata": {
- "id": "sRw9iL8pKP5O"
- },
- "execution_count": null,
- "outputs": []
+ ]
},
{
"cell_type": "markdown",
+ "metadata": {
+ "id": "xofUJym-_GuB"
+ },
"source": [
"Use the following code to run the pipeline.\n",
"\n",
"**Note:** Because this pipeline is a streaming pipeline, you need to
manually stop the cell. If you don't stop the cell, the pipeline continues to
run."
- ],
- "metadata": {
- "id": "xofUJym-_GuB"
- }
+ ]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {
- "id": "St07XoibcQSb",
"colab": {
"base_uri": "https://localhost:8080/";,
"height": 1000
},
+ "id": "St07XoibcQSb",
"outputId": "34e0a603-fb77-455c-e40b-d15b672edeb2"
},
"outputs": [
{
- "output_type": "display_data",
"data": {
- "application/javascript": [
- "\n",
- " if (typeof window.interactive_beam_jquery ==
'undefined') {\n",
- " var jqueryScript =
document.createElement('script');\n",
- " jqueryScript.src =
'https://code.jquery.com/jquery-3.4.1.slim.min.js';\n",
- " jqueryScript.type = 'text/javascript';\n",
- " jqueryScript.onload = function() {\n",
- " var datatableScript =
document.createElement('script');\n",
- " datatableScript.src =
'https://cdn.datatables.net/1.10.20/js/jquery.dataTables.min.js';\n",
- " datatableScript.type = 'text/javascript';\n",
- " datatableScript.onload = function() {\n",
- " window.interactive_beam_jquery =
jQuery.noConflict(true);\n",
- "
window.interactive_beam_jquery(document).ready(function($){\n",
- " \n",
- " });\n",
- " }\n",
- " document.head.appendChild(datatableScript);\n",
- " };\n",
- " document.head.appendChild(jqueryScript);\n",
- " } else {\n",
- "
window.interactive_beam_jquery(document).ready(function($){\n",
- " \n",
- " });\n",
- " }"
- ]
+ "application/javascript": "\n if (typeof
window.interactive_beam_jquery == 'undefined') {\n var jqueryScript =
document.createElement('script');\n jqueryScript.src =
'https://code.jquery.com/jquery-3.4.1.slim.min.js';\n
jqueryScript.type = 'text/javascript';\n jqueryScript.onload =
function() {\n var datatableScript =
document.createElement('script');\n datatableScript.src =
'https://cdn.datatables.net/1.10.20/js/jquery.dataTables.min.js';\n
datatableScript.type = 'text/javascript';\n datatableScript.onload =
function() {\n window.interactive_beam_jquery =
jQuery.noConflict(true);\n
window.interactive_beam_jquery(document).ready(function($){\n \n
});\n }\n
document.head.appendChild(datatableScript);\n };\n
document.head.appendChild(jqueryScript);\n } else {\n
window.interactive
_beam_jquery(document).ready(function($){\n \n });\n
}"
Review Comment:
would it make sense to clear the outputs in the notebook?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
