m-trieu commented on code in PR #30653:
URL: https://github.com/apache/beam/pull/30653#discussion_r1542055672
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/DataflowExecutionContextTest.java:
##########
@@ -184,4 +195,39 @@ public void
testDataflowExecutionStateTrackerRecordsCompletedProcessingTimes()
Assert.assertEquals(
expectedMetadata.userStepName(),
tracker.getActiveMessageMetadata().get().userStepName());
}
+
+ @Test
+ public void
testDataflowExecutionStateTrackerDoesNotRecordCompletedProcessingTimesForBatch()
Review Comment:
do we need to add a test to show that it does record for streaming?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
