liferoad commented on PR #30771: URL: https://github.com/apache/beam/pull/30771#issuecomment-2024119891
> Turns out I jumped the gun and there are more than just lint failures. There were a few true tests failures that came up from actual tests that weren't actually using `assert_that` correct. I fixed a few but all the `groupby` example tests weren't trivial to fix. I confirmed that if I changed the assertion in those tests, they would've always passed before the changes in this PR So what is the plan here? close this PR for now or you want to keep working on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
