riteshghorse commented on code in PR #30770:
URL: https://github.com/apache/beam/pull/30770#discussion_r1542996292
##########
sdks/python/apache_beam/io/avroio.py:
##########
@@ -693,29 +727,44 @@ def beam_row_to_avro_dict(
return lambda row: convert(row[0])
+# convert a beam atomic value to an avro atomic value
+# since numeric values are converted to unsigned in
+# avro_atomic_value_to_beam_atomic_value we need to convert
+# back to a signed number
+def beam_atomic_value_to_avro_atomic_value(avro_type: str, value):
Review Comment:
Nit: consider using docstring for function documentation. (same for other
functions)
```suggestion
def beam_atomic_value_to_avro_atomic_value(avro_type: str, value):
"""convert a beam atomic value to an avro atomic value
since numeric values are converted to unsigned in
avro_atomic_value_to_beam_atomic_value we need to convert
back to a signed number.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
