Amar3tto commented on PR #30687: URL: https://github.com/apache/beam/pull/30687#issuecomment-2025623347
> Because each jacoco report does not cover the whole java code base, in order to get accurate coverage, previously the jacoco is only included in certain paths, e.g. > > https://github.com/apache/beam/blob/6ce85e5f8ae908024c2b22afd06901551ce72a49/.test-infra/jenkins/job_PreCommit_SQL.groovy#L50 > > and https://github.com/apache/beam/blob/release-2.49.0/.test-infra/jenkins/job_PreCommit_Java.groovy is it able to retain this behavior? > basically, "precommit java" does not run tests in "sdks/java/io" and "sdks/java/extensions/sql"; and GCP_IO only run tests in "sdks/java/io/google-cloud-platform" and "sdks/java/extensions/sql" Yes, currently we will get reports only for _PreCommit_Java_ (will **not** generate specific IOs reports because does not run tests in "sdks/java/io"), _GCP IO_ and _SQL_. If we want to have the reports for the whole java code base, we will need to add this flag `-PenableJacocoReport` to the specific workflows (e.g. _beam_PreCommit_Java_Kafka_IO_Direct, beam_PreCommit_Java_Jms_IO_Direct_, ...). We can do that, but if I'm not mistaken, you mentioned that all the reports might take up too much space. If your question was about _'inclusionPattern'_ then yes, it works correctly, it only includes what is needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
