kennknowles commented on PR #30797: URL: https://github.com/apache/beam/pull/30797#issuecomment-2037849642
> OK I have done a whole massive revision and tested it a little bit more. > > The only piece that I have not revised is the `IcebergCatalogConfig` which gets turned into an `org.apache.iceberg.catalog.Catalog` on the client and each worker separately. I think your suggestion was to try to use just a big key-value map for all the config values. I am fine with that. I don't really know enough about it yet. All my deep dives into iceberg Java libraries was for other pieces. It looks like this might work: https://github.com/tabular-io/iceberg-kafka-connect/blob/5ab5c538efab9ccf3cde166f36ba34189eed7187/kafka-connect/src/main/java/io/tabular/iceberg/connect/IcebergSinkConfig.java#L256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
