johnjcasey commented on code in PR #30869:
URL: https://github.com/apache/beam/pull/30869#discussion_r1553965228


##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerTransformRegistrar.java:
##########
@@ -341,6 +346,9 @@ public PTransform<PCollection<Row>, PDone> buildExternal(
               .withDatabaseId(configuration.databaseId)
               .withInstanceId(configuration.instanceId);
 
+      if (configuration.highPriority != null && configuration.highPriority) {

Review Comment:
   is it worth defaulting to false just so you can avoid a null check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@beam.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to