Abacn commented on PR #30849: URL: https://github.com/apache/beam/pull/30849#issuecomment-2040478988
checked that if revert the change, the added unit test failed with ``` java.lang.AssertionError at org.junit.Assert.fail(Assert.java:87) at org.junit.Assert.assertTrue(Assert.java:42) at org.junit.Assert.assertFalse(Assert.java:65) at org.junit.Assert.assertFalse(Assert.java:75) at org.apache.beam.runners.flink.translation.wrappers.streaming.io.source.unbounded.FlinkUnboundedSourceReaderTest.testCheckMarksFinalized(FlinkUnboundedSourceReaderTest.java:306) ``` anyone able to confirm this has fixed the issue? CC: @anartemp @gfalcone @noster-dev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org