damccorm commented on code in PR #30788:
URL: https://github.com/apache/beam/pull/30788#discussion_r1554223645
##########
website/www/site/content/en/documentation/transforms/python/aggregation/approximatequantiles.md:
##########
@@ -17,7 +17,14 @@ limitations under the License.
# ApproximateQuantiles
+{{< localstorage language language-py >}}
+
+{{< button-pydoc path="apache_beam.transforms.stat"
class="ApproximateQuantile" >}}
+
## Examples
-See [Issue 19547](https://github.com/apache/beam/issues/19547) for updates.
+
+{{< playground height="700px" >}}
+{{< playground_snippet language="py" path="SDK_PYTHON_ApproximateQuantiles"
show="approximatequantiles" >}}
+{{< /playground >}}
Review Comment:
There's not a great single time to merge since we'd want the playground on
the release branch, so we'd want to merge the playground fixes, wait a week or
so for the release, then merge the website changes.
With that said, if you definitely don't have time we can merge right before
the release branch is cut (I'm running the release so should be easy for me to
pick up) and the website will just be broken for a bit in these code samples.
It isn't ideal, but would probably still be better than not doing this at all.
Up to you on how to proceed here, I'll add this as a release blocker so I
remember to merge though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
