jbsabbagh commented on code in PR #30877:
URL: https://github.com/apache/beam/pull/30877#discussion_r1555959733
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaDoFn.java:
##########
@@ -518,7 +525,7 @@ private ConsumerRecords<byte[], byte[]> poll(
return rawRecords;
}
elapsed = sw.elapsed();
- if (elapsed.toMillis() >= KAFKA_POLL_TIMEOUT.toMillis()) {
+ if (elapsed.toMillis() >= consumerPollingTimeout.toMillis()) {
// timeout is over
return rawRecords;
Review Comment:
In the case where the `rawRecords.isEmpty()`, might be worth adding some
sort of count that tracks how many times `rawRecords` has been empty. If this
count is too high, maybe emit a warning log that it is happening too often and
that perhaps the user should increase the poll timeout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
