liferoad commented on code in PR #30894:
URL: https://github.com/apache/beam/pull/30894#discussion_r1556620836
##########
sdks/python/apache_beam/runners/dataflow/dataflow_runner.py:
##########
@@ -415,6 +416,12 @@ def run_pipeline(self, pipeline, options,
pipeline_proto=None):
self.proto_pipeline, self.proto_context = pipeline.to_runner_api(
return_context=True, default_environment=self._default_environment)
+ if any(pcoll.is_bounded == beam_runner_api_pb2.IsBounded.UNBOUNDED
+ for pcoll in self.proto_pipeline.components.pcollections.values()):
+ options.view_as(StandardOptions).streaming = True
Review Comment:
if users specify streaming, can we honor the one specified by the users?
This at least can let users keep the current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
