kennknowles commented on code in PR #30902:
URL: https://github.com/apache/beam/pull/30902#discussion_r1557888856
##########
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamAggregateProjectMergeRuleTest.java:
##########
@@ -106,44 +106,6 @@ public void
testBeamAggregateProjectMergeRule_withProjectTable_withPredicate() {
ioSourceRel.getRowType().getFieldNames(), containsInAnyOrder("name",
"id", "unused1"));
}
- @Test
Review Comment:
Can we keep the test with `@Ignore("BeamAggregateProjectMergeRule disabled
due to <calcite bug link>")` ?
##########
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rule/BeamAggregateProjectMergeRuleTest.java:
##########
@@ -106,44 +106,6 @@ public void
testBeamAggregateProjectMergeRule_withProjectTable_withPredicate() {
ioSourceRel.getRowType().getFieldNames(), containsInAnyOrder("name",
"id", "unused1"));
}
- @Test
- public void testBeamAggregateProjectMergeRule_withFilterTable() {
- // When an IO does not supports project push-down, Projects should be
merged with an aggregate.
- String sqlQuery = "select SUM(id) as id_sum from TEST_FILTER group by
name";
- BeamRelNode beamRel = sqlEnv.parseQuery(sqlQuery);
-
- BeamAggregationRel aggregate = (BeamAggregationRel) beamRel.getInput(0);
- BeamIOSourceRel ioSourceRel = (BeamIOSourceRel) aggregate.getInput();
-
- // Make sure project merged with an aggregate.
- assertThat(aggregate.getRowType().getFieldNames(),
containsInAnyOrder("id_sum", "name"));
-
- // IO projects al fields.
- assertThat(ioSourceRel, instanceOf(BeamIOSourceRel.class));
- assertThat(
- ioSourceRel.getRowType().getFieldNames(),
- containsInAnyOrder("unused1", "name", "id", "unused2"));
- }
-
- @Test
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
