kennknowles commented on code in PR #30805: URL: https://github.com/apache/beam/pull/30805#discussion_r1558431502
########## sdks/java/io/iceberg/src/main/java/org/apache/beam/io/iceberg/IcebergIO.java: ########## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.io.iceberg; + +import java.util.Arrays; +import org.apache.beam.sdk.transforms.PTransform; +import org.apache.beam.sdk.transforms.SerializableBiFunction; +import org.apache.beam.sdk.transforms.SerializableFunctions; +import org.apache.beam.sdk.values.PCollection; +import org.apache.iceberg.Table; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.data.Record; +import org.checkerframework.checker.nullness.qual.NonNull; + +public class IcebergIO { + + public enum ScanType { + TABLE, + BATCH + } + + public static <ElementT, DestinationT> Write<ElementT, DestinationT> writeToDestinations( + IcebergCatalog catalog, + DynamicDestinations<ElementT, DestinationT> dynamicDestinations, + SerializableBiFunction<Record, ElementT, Record> toRecord) { + return new Write<>(catalog, dynamicDestinations, toRecord); + } + + public static TableFactory<String> forCatalog(final IcebergCatalog catalog) { + return new TableFactory<String>() { + @Override + public Table getTable(String id) { + TableIdentifier tableId = TableIdentifier.parse(id); + // If the first element in the namespace is our catalog, remove that. + if (tableId.hasNamespace()) { + Namespace ns = tableId.namespace(); + if (catalog.catalog().name().equals(ns.level(0))) { + String[] levels = ns.levels(); + @SuppressWarnings("nullness") // we know that copyOfRange will not do any padding + @NonNull + String[] levelsMinusFirst = Arrays.copyOfRange(levels, 1, levels.length); + tableId = TableIdentifier.of(Namespace.of(levelsMinusFirst), tableId.name()); + } + } + return catalog.catalog().loadTable(tableId); + } + }; + } + + public static class Write<ElementT, DestinationT> Review Comment: Thanks for noticing. I will revert any added write stuff in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@beam.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
