riteshghorse commented on code in PR #30880:
URL: https://github.com/apache/beam/pull/30880#discussion_r1561952478
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -875,15 +875,15 @@ def create_java_builtin_provider():
# where possible. This would also require extra care in skipping these
# common transforms when doing the provider affinity analysis.
- def java_window_into(java_provider, **config):
+ def java_window_into(java_provider, windowing):
"""Parses the config into a WindowingStrategy and invokes the Java class.
Review Comment:
```suggestion
"""Use the `windowing` WindowingStrategy and invokes the Java class.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
