TheNeuralBit commented on pull request #12573: URL: https://github.com/apache/beam/pull/12573#issuecomment-677773121
@robertwb, @robinyqiu - In this PR I've mapped python's Timestamp (microsecond precision) to the millis_instant logical type lossily so it could be mapped to DATETIME on the Java side and used in SQL. Based on discussion in https://github.com/apache/beam/pull/12493, now I'm thinking the better answer would be to add a micros_instant logical type so Python's data can go across the xlang boundary faithfully, and it's up to SQL to throw an error when the timestamp precision is too high, or silently drop precision if the user chooses. There's an open question about what to do if the output of the SqlTransform includes a millis_instant logical type. Would that still get mapped to a python Timestamp? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
