lukecwik edited a comment on pull request #12050: URL: https://github.com/apache/beam/pull/12050#issuecomment-677784438
> > We should update LocalResourceId and drop the isDirectory field > > I removed the `isDirectory` field, nevertheless I left `isDirectory` parameter in the constructor and the factory method untouched. WDYT? Makes sense since LocalResourceId constructor adds `File.separator` onto the path. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
