arvindram03 commented on code in PR #30693:
URL: https://github.com/apache/beam/pull/30693#discussion_r1566524587
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/DataflowOperationContext.java:
##########
@@ -185,41 +181,19 @@ public abstract static class DataflowExecutionState
extends ExecutionState {
private final ProfileScope profileScope;
private final @Nullable MetricsContainer metricsContainer;
- /** Clock used to either provide real system time or mocked to virtualize
time for testing. */
- private final Clock clock;
-
public DataflowExecutionState(
NameContext nameContext,
String stateName,
@Nullable String requestingStepName,
@Nullable Integer inputIndex,
@Nullable MetricsContainer metricsContainer,
ProfileScope profileScope) {
- this(
- nameContext,
- stateName,
- requestingStepName,
- inputIndex,
- metricsContainer,
- profileScope,
- Clock.SYSTEM);
- }
-
- public DataflowExecutionState(
- NameContext nameContext,
- String stateName,
- @Nullable String requestingStepName,
- @Nullable Integer inputIndex,
- @Nullable MetricsContainer metricsContainer,
- ProfileScope profileScope,
- Clock clock) {
super(stateName);
Review Comment:
Yes, we need to inititalize super class variables and set of variables
specific to this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
