tvalentyn commented on code in PR #31004:
URL: https://github.com/apache/beam/pull/31004#discussion_r1567972540
##########
sdks/python/setup.py:
##########
@@ -436,7 +436,9 @@ def get_portability_package_data():
],
'gcp': [
'cachetools>=3.1.0,<6',
- 'google-api-core>=2.0.0,<3',
+ # Temporary workaround until grpcio releases a fix for
+ # https://github.com/grpc/grpc/issues/36265
+ 'google-api-core>=2.0.0,!=2.17.*,!=2.18.*,<3',
Review Comment:
a lower bound restriction is prone to cause dependency resolution down the
road.
##########
sdks/python/setup.py:
##########
@@ -436,7 +436,9 @@ def get_portability_package_data():
],
'gcp': [
'cachetools>=3.1.0,<6',
- 'google-api-core>=2.0.0,<3',
+ # Temporary workaround until grpcio releases a fix for
+ # https://github.com/grpc/grpc/issues/36265
+ 'google-api-core>=2.0.0,!=2.17.*,!=2.18.*,<3',
Review Comment:
an upper bound restriction is prone to cause dependency resolution down the
road.
##########
sdks/python/setup.py:
##########
@@ -436,7 +436,9 @@ def get_portability_package_data():
],
'gcp': [
'cachetools>=3.1.0,<6',
- 'google-api-core>=2.0.0,<3',
+ # Temporary workaround until grpcio releases a fix for
+ # https://github.com/grpc/grpc/issues/36265
+ 'google-api-core>=2.0.0,!=2.17.*,!=2.18.*,<3',
Review Comment:
an upper bound restriction is prone to cause dependency resolution issues
down the road.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
