m-trieu commented on code in PR #31005:
URL: https://github.com/apache/beam/pull/31005#discussion_r1568345626
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingStepMetricsContainer.java:
##########
@@ -256,6 +270,11 @@ private void deleteStaleCounters(
// Metrics in 'deletedMetricNames' have either been removed from
'perWorkerCounters' or are no
// longer zero-valued.
perWorkerCountersByFirstStaleTime.keySet().removeAll(deletedMetricNames);
+
+ // Remove potentially deleted metric names from the cache. If these
metrics are non-zero valued
+ // in the future,
+ // they will automatically be added back to the cache.
Review Comment:
NIT: fix line break
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
