chamikaramj commented on code in PR #30460:
URL: https://github.com/apache/beam/pull/30460#discussion_r1569109482
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOTranslation.java:
##########
@@ -455,8 +454,8 @@ public Row toConfigRow(Write<?> transform) {
fieldValues.put(
"json_time_partitioning",
toByteArray(transform.getJsonTimePartitioning().get()));
}
- if (transform.getClustering() != null) {
- fieldValues.put("clustering", toByteArray(transform.getClustering()));
+ if (transform.getJsonClustering() != null) {
Review Comment:
You don't need to fork here but you need to fork at `fromConfigRow` if you
introduce a new field since trying to pull a non existent field from a Row will
result in an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
