damondouglas opened a new pull request, #31028: URL: https://github.com/apache/beam/pull/31028
# About This PR addresses #29669 connecting Web UI cancel requests with the backend Job Management server. # Changes - Fixes loading of CANCELED state for previously canceled Jobs - Triggers Web request from UI to backend on cancel clicks - Adds to /job/cancel http handler more detailed error reporting # Testing In addition to `go test ...`, manual testing of this PR was as follows: 1. Run prism via `go run ./go/cmd/prism` 2. Execute example via `go run ./go/examples/large_wordcount --output=/tmp/large_wordcount/out --runner=universal --endpoint=localhost:8073 --environment_type=LOOPBACK` 3. Validate job display in web console at http://localhost:8074/job/job-001 with state `RUNNING` 4. Click Cancel button 5. Validate cancel-related log messages populate in console after [filtering for debug level logs](https://developer.chrome.com/docs/devtools/console/log#level) 6. Validate Cancel button disabled with Job state change from `RUNNING` to `CANCELLING` 7. On reload of http://localhost:8074/job/job-001, validate state is `CANCELLED` 8. Navigating to http://localhost:8074 shows job-001 in Jobs list as `CANCELED` ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - ~Update `CHANGES.md` with noteworthy changes.~ - ~If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).~ See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
