tvalentyn commented on code in PR #30991:
URL: https://github.com/apache/beam/pull/30991#discussion_r1569805506
##########
sdks/python/apache_beam/runners/common.py:
##########
@@ -926,31 +922,16 @@ def _invoke_process_per_window(self,
additional_kwargs,
):
# type: (...) -> Optional[SplitResultResidual]
-
if self.has_windowed_inputs:
assert len(windowed_value.windows) <= 1
window, = windowed_value.windows
- side_inputs = [si[window] for si in self.side_inputs]
- side_inputs.extend(additional_args)
- args_for_process, kwargs_for_process = util.insert_values_in_args(
- self.args_for_process, self.kwargs_for_process,
- side_inputs)
- elif self.cache_globally_windowed_args:
- # Attempt to cache additional args if all inputs are globally
- # windowed inputs when processing the first element.
- self.cache_globally_windowed_args = False
-
- # Fill in sideInputs if they are globally windowed
Review Comment:
Is my understanding correct that the fundamental flaw in this logic is that
even for a global window, the sideinput can refresh if a window has a trigger
configured?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
