chamikaramj commented on code in PR #30910: URL: https://github.com/apache/beam/pull/30910#discussion_r1571175210
########## sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/DynamicDestinations.java: ########## @@ -15,7 +15,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.beam.io.iceberg; +package org.apache.beam.sdk.io.iceberg; Review Comment: I don't think Java only types are completely avoidable (at least without a significant refactoring). I think the main concern is failing to deserialize objects when upgrading the Java transform in the future. So we implemented `Externalizable` and added customer serializations that should be future proof for Java only types used here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
