chamikaramj commented on code in PR #31086:
URL: https://github.com/apache/beam/pull/31086#discussion_r1576839355
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/RecordWriter.java:
##########
@@ -92,7 +96,15 @@ public long bytesWritten() {
return icebergDataWriter.length();
}
- public DataFile dataFile() {
- return icebergDataWriter.toDataFile();
+ public ManifestFile getManifestFile() throws IOException {
+ String manifestFilename = FileFormat.AVRO.addExtension(absoluteFilename +
".manifest");
Review Comment:
Seems like this file will end up being named
`<absoluteFilename>.manifest.avro`. Just pointing out in case we want to avoid
double extension.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
