kennknowles commented on PR #31087:
URL: https://github.com/apache/beam/pull/31087#issuecomment-2082977457
Totally agree. I do know that this was actually an explicit decision. The
history as I understand it:
- We already had `View.asIterable` that was a simple iterator, but windowed
side inputs had awful performance because it was just a filter on the whole
side input
- We added `View.asList` primarily as an indicator that the per-window
value could be cached in memory after the first read.
- We added ISM format and for some reason emphasized the random access
behavior of the Java `List` class.
TBH I would be perfectly happy if we had never allowed random access for
list side inputs, leaving that to map side inputs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]