Abacn commented on code in PR #30824:
URL: https://github.com/apache/beam/pull/30824#discussion_r1585079959
##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -832,15 +857,17 @@ public Read withMetadata() {
/**
* Provide a scroll keepalive. See <a
*
href="https://www.elastic.co/guide/en/elasticsearch/reference/7.17/search-request-scroll.html";>scroll
- * API</a> Default is "5m". Change this only if you get "No search context
found" errors.
+ * API</a> Default is "5m". Change this only if you get "No search context
found" errors. When
+ * configuring the read to use Point In Time (PIT) search this
configuration is used to set the
+ * PIT keep alive.
*
* @param scrollKeepalive keepalive duration of the scroll
* @return a {@link PTransform} reading data from Elasticsearch.
*/
public Read withScrollKeepalive(String scrollKeepalive) {
- checkArgument(scrollKeepalive != null, "scrollKeepalive can not be
null");
- checkArgument(!"0m".equals(scrollKeepalive), "scrollKeepalive can not be
0m");
- return builder().setScrollKeepalive(scrollKeepalive).build();
+ checkArgument(scrollKeepalive != null, "iteratorKeepalive can not be
null");
Review Comment:
please fix these error messages also (revert change)
##########
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java:
##########
@@ -773,10 +792,16 @@ abstract static class Builder {
abstract Builder setWithMetadata(boolean withMetadata);
- abstract Builder setScrollKeepalive(String scrollKeepalive);
+ abstract Builder setIteratorKeepalive(String iteratorKeepalive);
Review Comment:
and here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
