Abacn commented on code in PR #31168:
URL: https://github.com/apache/beam/pull/31168#discussion_r1589231524
##########
.github/actions/setup-default-test-properties/test-properties.json:
##########
@@ -14,7 +14,7 @@
},
"JavaTestProperties": {
"SUPPORTED_VERSIONS": ["8", "11", "17"],
- "FLINK_VERSIONS": ["1.13", "1.14", "1.15"],
Review Comment:
just a side note
this is stale implies this field is not used, actually currently this action
is only used in update_python_dependencies and publish_github_release_notes
workflow.
Currently there is hard coded python/java versions everywhere in our GHAs.
As futurre clean up we could make use of this action to have single source of
version setting for actions
##########
sdks/python/apache_beam/options/pipeline_options.py:
##########
@@ -1591,7 +1591,7 @@ def _add_argparse_args(cls, parser):
class FlinkRunnerOptions(PipelineOptions):
# These should stay in sync with gradle.properties.
- PUBLISHED_FLINK_VERSIONS = ['1.12', '1.13', '1.14', '1.15', '1.16']
Review Comment:
note - this would essentially prevent python user using flink 1.17 for Beam
2.56.0, and not prevent user choosing 1.12,1.13. Consider update the known
issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
