damccorm commented on code in PR #30793:
URL: https://github.com/apache/beam/pull/30793#discussion_r1589346078
##########
sdks/python/apache_beam/yaml/yaml_provider.py:
##########
@@ -152,6 +169,17 @@ def __init__(self, urns, service):
def provided_transforms(self):
return self._urns.keys()
+ def with_underlying_provider(self, other_provider):
+ if not isinstance(other_provider, ExternalProvider):
+ return
+
+ all_urns = set(other_provider.schema_transforms().keys()).union(
Review Comment:
> Hmm... the only thing red was coverage in the presubmits.
Yeah, I noticed this - I'm not sure why... It looks like the failures are
around 2.57.0.dev, so it could be some versioning issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
