camphillips22 commented on code in PR #31174:
URL: https://github.com/apache/beam/pull/31174#discussion_r1589421878


##########
sdks/go/pkg/beam/runners/prism/internal/coders.go:
##########
@@ -187,6 +187,30 @@ func reconcileCoders(bundle, base 
map[string]*pipepb.Coder) {
        }
 }
 
+func reconcileWindowCoders(bundle, base map[string]*pipepb.Coder, ws 
map[string]*pipepb.WindowingStrategy) {

Review Comment:
   I might open a separate PR for this, but without this, prism will error 
because the coder passed through the instruction is not included when there are 
multiple windowing strategies.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to