an2x opened a new pull request, #31175: URL: https://github.com/apache/beam/pull/31175
This is a continuation of https://github.com/apache/beam/pull/25922 and an attempt to fix an issue with Dataflow logging, when log messages sometimes get corrupted. DataflowWorkerLoggingHandler logs message to a physical file, then a separate process in Dataflow reads this file and exports logs to Cloud Logging. I found that the Jackson generator used by DataflowWorkerLoggingHandler has the SerializationFeature.FLUSH_AFTER_WRITE_VALUE feature enabled by default, which makes it flush the JSON output to the underlying stream after every object write. DataflowWorkerLoggingHandler currently writes the "severity" field as an object (generator.writeObjectField("severity", ...))., which results in the log message being flushed between "severity" and "message" fields, and some time Dataflow logging infrastructure pick this up as 2 separate message (both unparsable as JSON, with broken formatting/wrong severity). Disabling SerializationFeature.FLUSH_AFTER_WRITE_VALUE should fix this issue (and improve logging performance a little bit). **Please** add a meaningful description for your change here ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
